Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gix blame --since #1858

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cruessler
Copy link
Contributor

This PR adds support for --since=<date> to gix blame. I’ve run a couple of manual tests on my machine and the results seem to match git’s results (apart from differences due to the slider problem as far as I can see).

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks so much!

I have one tiny nit for Option, and would merge right after this lands. I will wait until you have integrated it, but would also make it happen tomorrow morning if you don't get to it.

@@ -7,6 +7,16 @@ use std::{
ops::{AddAssign, Range, SubAssign},
};

/// Options to be passed to [`file()`](crate::file()).
pub struct Options {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pub struct Options {
#[derive(Default, Debug, Clone)
pub struct Options {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion, applied!

@cruessler
Copy link
Contributor Author

One thing I forgot to mention: there’s now an inconsistency between commit_time and other functions taking commit: Either as a parameter as commit_time borrows it as opposed to taking ownership.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants